smart-facility / petajakarta-web

Web files for PetaJakarta.org
http://petajakarta.org
Other
8 stars 6 forks source link

Floodgauge chart showing too much data #72

Closed matthewberryman closed 8 years ago

matthewberryman commented 8 years ago

The chart shows too much data, resulting in numbers being cut off in scales for both axes, and a cluttered x-axis scale. This is I believe independent of the duplicate data bug #70 as it would be still present once you've collected enough data. image

matthewberryman commented 8 years ago

Looking back at #70 screenshots, the scale on the y axis is cut off there too, even with a reasonable amount of data points.

tomasholderness commented 8 years ago

The cut off problem is now fixed (it was a formatting issue).

Note that now the duplicate report bug is also fixed (#70), graphs should show a maximum of 12 hours worth of reports (which should fit reasonably within the graph). This value is controled by the cognicity-server config parameter config.api.floodgauges.time_window

Given its the weekend, if we leave the floodgauges reports module running (which it appears to be) you should notice complete fixes on the graphs over the next 8 hours or so, whilst the remaining duplicate reports are cleared from the API.

matthewberryman commented 8 years ago

Ok I am happy to close this then. It's starting to look better now for this and for #70 on iPhone, will check with iPad but behaviour should be better there too.