Map.js - getREM doesn't make use of TopoJSON

smart-facility / petajakarta-web

Web files for PetaJakarta.org

http://petajakarta.org

Other

8 stars 6 forks source link

Map.js - getREM doesn't make use of TopoJSON #95

Closed tomasholderness closed 8 years ago

tomasholderness commented 8 years ago

Increases load time of petajakarta.org between 0.5 and 1 second.

https://github.com/smart-facility/petajakarta-web/blob/master/banjir/assets/js/map.js#L246

Need to add:

callback(topojson.feature(data, data.objects.collection));

matthewberryman commented 8 years ago

@talltom I'm also going to have a separate look at caching rules as well.

tomasholderness commented 8 years ago

@matthewberryman - cool, I've closed this, as just pushed updated. Will deploy shortly.

But, perhaps take a look at cache on rem-server? Chrome profiling indicates that TTFB when polling REM API is longest component in loading this data (FYI screenshot running on local host, but connecting to REM on prod).

matthewberryman commented 8 years ago

Yes that's what I meant.