smart-leds-rs / smart-leds-trait

A trait for implementing effects, modifiers and drivers for programmable leds
Apache License 2.0
2 stars 4 forks source link

Documentation hint about color space incorrect #8

Closed Finomnis closed 1 year ago

Finomnis commented 1 year ago

Quote from the documentation of RGB8:

The colorspace is techincally undefined, but generally sRGB is assumed.

This is incorrect. Most LED strips use Linear sRGB, not normal, gamma corrected sRGB color space.

More detail about the difference can be found here: https://matt77hias.github.io/blog/2018/07/01/linear-gamma-and-sRGB-color-spaces.html

My experience is that LED strips try to be as close as possible to the linear brightness scale, some even use high-speed PWM to achieve that. (like the sk6805/sk6812)

Therefore I propose two things: