smart-leds-rs / smart-leds

The end user crate for smart leds (like ws2812)
Apache License 2.0
95 stars 13 forks source link

Initial hsv implementation #2

Closed david-sawatzke closed 5 years ago

david-sawatzke commented 5 years ago

Should we move the Hsv struct into the traits crate? Should we add an iterator based conversation (Not sure if it's fast enough)?

This is mostly a port of the fast-led code, of the spectrum variant https://github.com/FastLED/FastLED/wiki/FastLED-HSV-Colors.

sajattack commented 5 years ago

I think this is a good spot for it.

sajattack commented 5 years ago

Sorry to nitpick but you misspelled protocol in the README.

david-sawatzke commented 5 years ago

Good catch

sajattack commented 5 years ago

LGTM