search

smart-leds-rs / smart-leds

The end user crate for smart leds (like ws2812)
Apache License 2.0
95 stars 13 forks source link

initial gamma correction implementation #3

Closed sajattack closed 5 years ago

sajattack commented 5 years ago

Using a lookup table, I think the on-the-fly method would be too slow. Here's a shitty gif showing orange (looks yellow) versus gamma-corrected orange (looks a bit too red in this gif but better irl): gif Do you want me to add this demo to smart-leds-samples?

david-sawatzke commented 5 years ago

Adding an example is a good idea. Not too happy about the lookup table, but you're probably right about it being too slow. A note about this fixing the colors & that gamma correction should come after the brightness adjustment would be great.

sajattack commented 5 years ago

I did the gamma correction and then the brightness, that's wrong?

david-sawatzke commented 5 years ago

Sorry that wasn't very clear. I just want to add a note about that in the doc comments