search

smart-on-fhir / client-py

Python SMART on FHIR client
http://docs.smarthealthit.org
Other
591 stars 211 forks source link

Regenerate models based off of R4 (4.0.1) #149

Closed mikix closed 3 months ago

mikix commented 3 months ago

Also:

mikix commented 3 months ago

I'm taking your word at face value on the generated models - if you want me to side by side them against the FHIR spec, lemme know.

Yes I'm confident. I just went through them again with git diff -- fhirclient/models ':(exclude)*_tests.py'.

HOWEVER, I did forget to mention an actual change. This is in a few classes. A few times in the spec, a class will have a "choice" field that can be different types (like valueDateTime and valueBoolean). And sometimes that choice is "any element type" -- see the defaultValue[x] and fixed[x] fields in ElementDefinition.

In 4.0.1, the element type "Meta" got added to all those choice fields. So if you look at elementdefinition.py in this PR, you'll see an example of that. It's all just additive. And it does seem to be correct per the spec.