smart-on-fhir / client-py

Python SMART on FHIR client
http://docs.smarthealthit.org
Other
591 stars 211 forks source link

Overhaul how date & time parsing works. #164

Closed mikix closed 3 months ago

mikix commented 3 months ago

Note: I want to prepare a simultaneous PR for fhir-parser, since it will need the same sort of fixes. But that version does not need to maintain backwards compatibility, so it will be a useful comparison for how we might want this to look when we next bump major versions. That's coming shortly.

This commit breaks FHIRDate into four classes:

BREAKING CHANGES:

Since the first item is unavoidable if we want to fix the bugs listed below and has a workaround that works before and after this change, and the second item is not an expected workflow, I hope that such breaking changes do not cause too much harm for consumers.

BUG FIXES:

IMPROVEMENTS:

This is a sister PR (one which maintains some level of backwards compatibility) to the upstream more drastic refactor in fhir-parser.

Fixes: #32 Fixes: #11