smart-on-fhir / cumulus-library-data-metrics

A data metrics study for the Cumulus project
https://docs.smarthealthit.org/cumulus/
Apache License 2.0
2 stars 0 forks source link

q_ref_target_valid: change denominator from fields to rows #37

Closed mikix closed 5 months ago

mikix commented 5 months ago

Before, we would count all potential matching Reference fields as the denominator. This commit aligns us back with the qualifier metric documentation to just use all rows as the denominator.

In cases like DocumentReference.context.encounter that can have multiple references, we include the row once in the numerator and concatenate the target values for debugging.

Noticed this discrepancy during a recent qualifier doc read-through.