smart-on-fhir / cumulus-library

https://docs.smarthealthit.org/cumulus/library/
Apache License 2.0
2 stars 0 forks source link

Common SQL Gen updates to support all studies #107

Closed comorbidity closed 1 year ago

comorbidity commented 1 year ago

SQL gen count_encounter count_patient should have analogs for FHIR core table refs #100 https://github.com/smart-on-fhir/cumulus-library/issues/100

Import “study_prefix” into general ability to run counts generator https://github.com/smart-on-fhir/cumulus-library-template/issues/2

https://github.com/smart-on-fhir/cumulus-library/blob/31a38882f69f6843910f8abf0e173ba58589c566/cumulus_library/study_parser.py#L82

This is the most DRY violating thing currently in each study, because

def write_view_sql(view_list_sql: List[str], filename="count.sql") -> None:

Typical naming scheme

STUDY_PREFIX + “count” + name of the source table + duration (optional)

Where duration is ONLY: {Month, Week, or None}

Should we ALWAYS default to creating TABLES rather than views? = YES 100%

dogversioning commented 1 year ago

Resolved via #109