Replace null expected values in generated counts queries - Githubissues

smart-on-fhir / cumulus-library

https://docs.smarthealthit.org/cumulus/library/

Apache License 2.0

2 stars 0 forks source link

Replace null expected values in generated counts queries #156

Closed dogversioning closed 6 months ago

dogversioning commented 6 months ago

This PR makes the following changes:

Counts table results for fields that are unexpectedly empty are now coalesced to 'missing-or-null'
Moves the counts_builder infrastructure from 'schema' to 'statistics' for better semantic grouping
- Broke out counts template from the vanilla sql template gen
Added some jinja templating to counts template for better readability
pylint-related updates to some unit tests.

Note - this PR does not attempt to address #131, which i'm planning to do separately for cognitive load reasons.

Checklist

[X] Consider if documentation (like in docs/) needs to be updated
[X] Consider if tests should be added
[X] Run pylint if you're making changes beyond adding studies
[X] Update template repo if there are changes to study configuration