smart-on-fhir / cumulus-library

https://docs.smarthealthit.org/cumulus/library/
Apache License 2.0
2 stars 0 forks source link

core__study_period defines "ed_note" but this should not be present #198

Open comorbidity opened 3 months ago

comorbidity commented 3 months ago

@dogversioning is probably correct, even what constitutes a "documented ED visit" may vary from study to study. Therefore, each study should define the selection criteria and NOT have CORE perform this task.

ETL defines other note types as well, such as "discharge summary". This would be confusing for the user if they assumed "ed_note" meant documented encounter. Because "discharge summary" means you were admitted, but maybe the patient was NOT first at the emergency department! Here in ETL is a list of notes processed by NLP (provided by @mikix ) https://github.com/smart-on-fhir/cumulus-etl/blob/main/cumulus_etl/etl/studies/covid_symptom/covid_tasks.py#L16

Thus, @dogversioning is correct and @comorbidity heeds Matt's advice.