A couple miscellaneous fixes

smart-on-fhir / cumulus-library

https://docs.smarthealthit.org/cumulus/library/

Apache License 2.0

2 stars 0 forks source link

A couple miscellaneous fixes #200

Closed mikix closed 3 months ago

mikix commented 3 months ago

I found these while working on tests for a different upcoming PR.

Checklist

[x] Consider if documentation (like in docs/) needs to be updated
[x] Consider if tests should be added
[x] Update template repo if there are changes to study configuration

mikix commented 3 months ago

Can we modify/add some data to the duckdb json that will exercise these changes?

Yes, let me add my dumb little test that triggered these. Though it is a bit of a testing departure from the rest of the code - but I think it will be useful. Let me push up and you can comment.

mikix commented 3 months ago

OK updated to resolve your comments, and added a little test helper class I was working on, for more dynamic ndjson rather than ndjson that lives on disk in a folder. Felt easier to create little edge cases for. But it's a bit of a departure from the norm in this repo - I can adjust it to your taste.