core: fix typo in core__encounter.serviceType_code*

smart-on-fhir / cumulus-library

https://docs.smarthealthit.org/cumulus/library/

Apache License 2.0

2 stars 0 forks source link

core: fix typo in core__encounter.serviceType_code* #206

Closed mikix closed 2 months ago

mikix commented 2 months ago

This renames two new fields to core__encounter:

seviceType_code -> serviceType_code
seviceType_code_system -> serviceType_code_system

Checklist

[x] Consider if documentation (like in docs/) needs to be updated
[x] Consider if tests should be added
[x] Update template repo if there are changes to study configuration

mikix commented 2 months ago

I'm fine with whatever you wanna do here, but that feels like a pretty big semantic versioning cheat.

I'd personally either cut a 3.0 release with the fields cut, or leave the fields in. And I lean toward the latter, the typo fields being left in don't hurt anyone. :shrug:

mikix commented 2 months ago

OK, I updated this to match a paper-bag-release style (v2.0.1 with the typo fields removed).

dogversioning commented 2 months ago

OK, I updated this to match a paper-bag-release style (v2.0.1 with the typo fields removed).

i love shame! it's my favorite emotion