Seperated CLI actions from study_parser

smart-on-fhir / cumulus-library

https://docs.smarthealthit.org/cumulus/library/

Apache License 2.0

2 stars 0 forks source link

Seperated CLI actions from study_parser #245

Closed dogversioning closed 1 month ago

dogversioning commented 1 month ago

This PR makes the following changes:

Moves the logic of the various CLI actions into their own files
- Light refactoring to make actions functional rather than class based
renamed a lot of vars to more explictly indicate what things are parsing a manifest specifically

Checklist

[X] Consider if documentation (like in docs/) needs to be updated
[X] Consider if tests should be added
[X] Update template repo if there are changes to study configuration

dogversioning commented 1 month ago

Actions is fine! In an argparse sense, they are "subcommands" - in the ETL I usually use the word "command" for this kind of thing.

I thought about reusing subcommands, but since the CLI subcommands -> actions mapping is not exactly 1-1 (some clean is invoked before a build), i liked a little seperation.