Introduces a number of UI changes on the tails of our previous discussion. Key changes include:
Favicons have been updated to remove the blue V
Notifcation delay has been extended, from 4s to 7s
onMouseEnter of the notification will delete the decay timeout, and onMouseExit will reset it
AttachmentComponent's border has been deemphasized by using a lighter color
AttachmentComponent's borderRadius has been changed to be distinct from the jobDetailView's container's borderRadius
Color contrast on the logo and the header more generally has been improved by choosing a lighter background color
Many overflow issues have been dealt with, including but not limited to: patient-page's view of active jobs, admin view of all jobs, job-detail view's attachment component overflow
Text centering in the attachment component has been improved.
Color contrast on the highlightAttachment section has been improved by choosing a lighter background
Color starkness on Approve button has been made more bearable by choosing a less aggressive hover color
Better text wrapping in pre-styled components
src/components/ExportJobListItemSmall/index.tsx: redirect url param is based on window.location.origin, not hardcoded
New Export button is now aligned in the right-gutter of the page
Additional changes include:
Adding a fadeIn animation for the notifications
Adding more transition styling across hover-styled components (e.g. buttons)
Removed unused manifest file
Moved AppHeader logic into a separate component
AppHeader overflows better on small-sized screens
More prominent heading used in the ErrorMessage component
Disabled institutions communicate they are disabled, use a more gray bg color
src/pages/ExportLaunch/index.tsx: Dialog takes up slightly more space
Changes discussed but intentionally not included:
Adding more width to the container: I played with this around 1000px, and the additional width left the app feeling too empty for my taste. Happy to explore these options together in a screenshare if you'd like.
Phrasing on the upload section, the "up to...": I think this is fine to begin. We probably should be too caught up in the copy-editing before showing it to others, and I can defend this phrasing if pressed on it by others. Happy to change with more feedback, but will leave for now.
Trash-icons on attachment components only show on hover: Ignoring this for the moment, since we can control how cluttered the MVP feels in our demo. It's a good idea, but it also feels distinct enough to have it's own ticket.
Upload UI could be slower: Too much to explore for this task. Will make a separate ticket.
Error notification parsing when we get back a JSON response: This is good, but this will also be easier after I refactor various fetch calls to leverage the request utility fn. I will fold this change into that PR.
Let me know if there was anything else critical for me to address that I missed!
Introduces a number of UI changes on the tails of our previous discussion. Key changes include:
onMouseEnterof the notification will delete the decay timeout, andonMouseExitwill reset itpre-styled componentssrc/components/ExportJobListItemSmall/index.tsx: redirect url param is based onwindow.location.origin, not hardcodedAdditional changes include:
src/pages/ExportLaunch/index.tsx: Dialog takes up slightly more spaceChanges discussed but intentionally not included:
requestutility fn. I will fold this change into that PR.Let me know if there was anything else critical for me to address that I missed!