search

smart-on-fhir / growth-chart-app

Other
67 stars 98 forks source link

Fix for Growth Chart’s print functionality being extremely slow in IE. #39

Open shriniketsarkar-zz opened 7 years ago

shriniketsarkar-zz commented 7 years ago

Issue : The open source version of growth chart pops out a window for the print functionality. When the application is run in IE, launching the print window opens up the pop-up but the content is rendered extremely slow. This results in the user staring at a blank page for several seconds and sometimes minutes before any UI gets rendered on the screen. This gives the user an impression that the UI is stuck. More Info on this Issue : https://github.com/smart-on-fhir/growth-chart-app/issues/26

Fix : This PR fixes the slowness issue. The fix involves loading content on the popup window from the main growth chart window.

Changes : A new gc-print.html page is loaded when we click on the Print Icon on Main window. The Main GC window uses the rendered "Graph" and "Parent" views from the main window to be shown on the print popup based on the selection on the main window. If "Table" view is selected on the main window we redraw the table in a vertical orientation on the print popup.

Printing Considerations/Instructions : The user will need to print in landscape mode for Graph and Parent views where as portrait mode can be used for Table view.

shriniketsarkar-zz commented 6 years ago

@nschwertner @vlad-ignatov Can you guys take a look at this PR?