search

smart-on-fhir / sample-apps-stu3

Collection of simple sample apps
Other
47 stars 43 forks source link

Lock SMART JS client to version 0.1.12 to avoid breaking changes intr… #12

Closed nschwertner closed 5 years ago

nschwertner commented 5 years ago

…oduced in later versions

nschwertner commented 5 years ago

A couple of the sample apps are currently broken due to breaking changes introduced in the SMART JS client at https://github.com/smart-on-fhir/client-js/commit/19dbdb163797c28e01822f1b82ee96dd71b57a83 in the fetchAllWithReferences method of fhir.js. This provides a fix by locking down the library version used by the apps to the last known compatible version.

vlad-ignatov commented 5 years ago

Do you know what those breaking changes are exactly? I wonder if it can be fixed in client-js or in fhir.js.

hansenms commented 5 years ago

https://github.com/smart-on-fhir/sample-apps-stu3/issues/13

Is this problem.

Is the change in fetchAllWithReferences intentional? It is now returning a search bundle instead of an arry of results.

hansenms commented 5 years ago

I just put up this as an example of another workaround (for one app):

https://github.com/smart-on-fhir/sample-apps-stu3/pull/14

The question is if the breaking change in fhirclient was intentional or not. @vlad-ignatov ?