search

smart-underworld / seestar_alp

Complete Control and Automation for Seestar S50
Other
42 stars 24 forks source link

Clean up Retry logic #17

Closed rrowley42 closed 1 week ago

rrowley42 commented 1 week ago

The retry logic in seestar_device was cleaned up.

Restart logic was added if shutdown has been sent

In telescope.py, moveaxis had a small bug

rrowley42 commented 1 week ago

WileEyte was cycling the Seestar and didn’t want to also have to cycle Seestar_alp. I can remove it if you don’t think it is good enough use case.

From: smart-underworld @.> Sent: Wednesday, June 26, 2024 10:11 AM To: smart-underworld/seestar_alp @.> Cc: rrowley42 @.>; Author @.> Subject: Re: [smart-underworld/seestar_alp] Clean up Retry logic (PR #17)

@smart-underworld commented on this pull request.

Question about shutdown logic change. This was for users to shutdown and thus power off Seestar. Why is there logic to start seestar device again?

— Reply to this email directly, view it on GitHub https://github.com/smart-underworld/seestar_alp/pull/17#pullrequestreview-2142189094 , or unsubscribe https://github.com/notifications/unsubscribe-auth/APD2NM2RATD7V3BC533HJE3ZJLKYVAVCNFSM6AAAAABJ55FGPKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCNBSGE4DSMBZGQ . You are receiving this because you authored the thread.Message ID: @.***>

YungKC commented 1 week ago

It's probably better to interpret the shutdown request as to end the night session, and having the Seestar powered off. Ideally leave the app alive but with a log or message stating the device has been shutdown.

To power up Seestar again, that would be a new seestar_alp session.

On Wed, Jun 26, 2024, 8:21 AM rrowley42 @.***> wrote:

WileEyte was cycling the Seestar and didn’t want to also have to cycle Seestar_alp. I can remove it if you don’t think it is good enough use case.

From: smart-underworld @.> Sent: Wednesday, June 26, 2024 10:11 AM To: smart-underworld/seestar_alp @.> Cc: rrowley42 @.>; Author @.> Subject: Re: [smart-underworld/seestar_alp] Clean up Retry logic (PR #17)

@smart-underworld commented on this pull request.

Question about shutdown logic change. This was for users to shutdown and thus power off Seestar. Why is there logic to start seestar device again?

— Reply to this email directly, view it on GitHub < https://github.com/smart-underworld/seestar_alp/pull/17#pullrequestreview-2142189094> , or unsubscribe < https://github.com/notifications/unsubscribe-auth/APD2NM2RATD7V3BC533HJE3ZJLKYVAVCNFSM6AAAAABJ55FGPKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCNBSGE4DSMBZGQ> . You are receiving this because you authored the thread.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/smart-underworld/seestar_alp/pull/17#issuecomment-2191981580, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADWZ5DATTXDLAHABWL44ELZJLL7RAVCNFSM6AAAAABJ55FGPKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJRHE4DCNJYGA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

rrowley42 commented 1 week ago

Ok, I’m good with that.

Do you accept that pull and then I submit another pull for this change?

Or do you reject the pull?

Rod

From: YungKC @.> Sent: Wednesday, June 26, 2024 10:29 AM To: smart-underworld/seestar_alp @.> Cc: rrowley42 @.>; Author @.> Subject: Re: [smart-underworld/seestar_alp] Clean up Retry logic (PR #17)

It's probably better to interpret the shutdown request as to end the night session, and having the Seestar powered off. Ideally leave the app alive but with a log or message stating the device has been shutdown.

To power up Seestar again, that would be a new seestar_alp session.

On Wed, Jun 26, 2024, 8:21 AM rrowley42 @.***> wrote:

WileEyte was cycling the Seestar and didn’t want to also have to cycle Seestar_alp. I can remove it if you don’t think it is good enough use case.

From: smart-underworld @.> Sent: Wednesday, June 26, 2024 10:11 AM To: smart-underworld/seestar_alp @.> Cc: rrowley42 @.>; Author @.> Subject: Re: [smart-underworld/seestar_alp] Clean up Retry logic (PR #17)

@smart-underworld commented on this pull request.

Question about shutdown logic change. This was for users to shutdown and thus power off Seestar. Why is there logic to start seestar device again?

— Reply to this email directly, view it on GitHub < https://github.com/smart-underworld/seestar_alp/pull/17#pullrequestreview-2142189094> , or unsubscribe < https://github.com/notifications/unsubscribe-auth/APD2NM2RATD7V3BC533HJE3ZJLKYVAVCNFSM6AAAAABJ55FGPKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCNBSGE4DSMBZGQ> . You are receiving this because you authored the thread.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/smart-underworld/seestar_alp/pull/17#issuecomment-2191981580, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADWZ5DATTXDLAHABWL44ELZJLL7RAVCNFSM6AAAAABJ55FGPKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJRHE4DCNJYGA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/smart-underworld/seestar_alp/pull/17#issuecomment-2191998218 , or unsubscribe https://github.com/notifications/unsubscribe-auth/APD2NMZSWIMJ3G6RXTTP4OLZJLM4LAVCNFSM6AAAAABJ55FGPKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJRHE4TQMRRHA . You are receiving this because you authored the thread.Message ID: @.***>

rrowley42 commented 1 week ago

I thought about putting some comments in moveaxis in telescope.py to indicate the direction.

0 is right

90 is up

180 is left

270 is down

Took awhile to figure out.

From: YungKC @.> Sent: Wednesday, June 26, 2024 10:29 AM To: smart-underworld/seestar_alp @.> Cc: rrowley42 @.>; Author @.> Subject: Re: [smart-underworld/seestar_alp] Clean up Retry logic (PR #17)

It's probably better to interpret the shutdown request as to end the night session, and having the Seestar powered off. Ideally leave the app alive but with a log or message stating the device has been shutdown.

To power up Seestar again, that would be a new seestar_alp session.

On Wed, Jun 26, 2024, 8:21 AM rrowley42 @.***> wrote:

WileEyte was cycling the Seestar and didn’t want to also have to cycle Seestar_alp. I can remove it if you don’t think it is good enough use case.

From: smart-underworld @.> Sent: Wednesday, June 26, 2024 10:11 AM To: smart-underworld/seestar_alp @.> Cc: rrowley42 @.>; Author @.> Subject: Re: [smart-underworld/seestar_alp] Clean up Retry logic (PR #17)

@smart-underworld commented on this pull request.

Question about shutdown logic change. This was for users to shutdown and thus power off Seestar. Why is there logic to start seestar device again?

— Reply to this email directly, view it on GitHub < https://github.com/smart-underworld/seestar_alp/pull/17#pullrequestreview-2142189094> , or unsubscribe < https://github.com/notifications/unsubscribe-auth/APD2NM2RATD7V3BC533HJE3ZJLKYVAVCNFSM6AAAAABJ55FGPKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCNBSGE4DSMBZGQ> . You are receiving this because you authored the thread.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/smart-underworld/seestar_alp/pull/17#issuecomment-2191981580, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADWZ5DATTXDLAHABWL44ELZJLL7RAVCNFSM6AAAAABJ55FGPKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJRHE4DCNJYGA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/smart-underworld/seestar_alp/pull/17#issuecomment-2191998218 , or unsubscribe https://github.com/notifications/unsubscribe-auth/APD2NMZSWIMJ3G6RXTTP4OLZJLM4LAVCNFSM6AAAAABJ55FGPKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJRHE4TQMRRHA . You are receiving this because you authored the thread.Message ID: @.***>

YungKC commented 1 week ago

It's best practice to submit another PR to replace the earlier one.

On Wed, Jun 26, 2024, 8:31 AM rrowley42 @.***> wrote:

Ok, I’m good with that.

Do you accept that pull and then I submit another pull for this change?

Or do you reject the pull?

Rod

From: YungKC @.> Sent: Wednesday, June 26, 2024 10:29 AM To: smart-underworld/seestar_alp @.> Cc: rrowley42 @.>; Author @.> Subject: Re: [smart-underworld/seestar_alp] Clean up Retry logic (PR #17)

It's probably better to interpret the shutdown request as to end the night session, and having the Seestar powered off. Ideally leave the app alive but with a log or message stating the device has been shutdown.

To power up Seestar again, that would be a new seestar_alp session.

On Wed, Jun 26, 2024, 8:21 AM rrowley42 @.***> wrote:

WileEyte was cycling the Seestar and didn’t want to also have to cycle Seestar_alp. I can remove it if you don’t think it is good enough use case.

From: smart-underworld @.> Sent: Wednesday, June 26, 2024 10:11 AM To: smart-underworld/seestar_alp @.> Cc: rrowley42 @.>; Author @.> Subject: Re: [smart-underworld/seestar_alp] Clean up Retry logic (PR

17)

@smart-underworld commented on this pull request.

Question about shutdown logic change. This was for users to shutdown and thus power off Seestar. Why is there logic to start seestar device again?

— Reply to this email directly, view it on GitHub <

https://github.com/smart-underworld/seestar_alp/pull/17#pullrequestreview-2142189094>

, or unsubscribe <

https://github.com/notifications/unsubscribe-auth/APD2NM2RATD7V3BC533HJE3ZJLKYVAVCNFSM6AAAAABJ55FGPKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCNBSGE4DSMBZGQ>

. You are receiving this because you authored the thread.Message ID: @.***>

— Reply to this email directly, view it on GitHub < https://github.com/smart-underworld/seestar_alp/pull/17#issuecomment-2191981580>,

or unsubscribe < https://github.com/notifications/unsubscribe-auth/AADWZ5DATTXDLAHABWL44ELZJLL7RAVCNFSM6AAAAABJ55FGPKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJRHE4DCNJYGA>

. You are receiving this because you are subscribed to this thread.Message ID: @.***>

— Reply to this email directly, view it on GitHub < https://github.com/smart-underworld/seestar_alp/pull/17#issuecomment-2191998218> , or unsubscribe < https://github.com/notifications/unsubscribe-auth/APD2NMZSWIMJ3G6RXTTP4OLZJLM4LAVCNFSM6AAAAABJ55FGPKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJRHE4TQMRRHA> . You are receiving this because you authored the thread.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/smart-underworld/seestar_alp/pull/17#issuecomment-2192004352, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADWZ5BCB5NP3TWZW4W3VI3ZJLNGZAVCNFSM6AAAAABJ55FGPKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJSGAYDIMZVGI . You are receiving this because you commented.Message ID: @.***>

rrowley42 commented 1 week ago

Ok, will do.

On Wed, Jun 26, 2024 at 11:43 AM YungKC @.***> wrote:

It's best practice to submit another PR to replace the earlier one.

On Wed, Jun 26, 2024, 8:31 AM rrowley42 @.***> wrote:

Ok, I’m good with that.

Do you accept that pull and then I submit another pull for this change?

Or do you reject the pull?

Rod

From: YungKC @.> Sent: Wednesday, June 26, 2024 10:29 AM To: smart-underworld/seestar_alp @.> Cc: rrowley42 @.>; Author @.> Subject: Re: [smart-underworld/seestar_alp] Clean up Retry logic (PR

17)

It's probably better to interpret the shutdown request as to end the night session, and having the Seestar powered off. Ideally leave the app alive but with a log or message stating the device has been shutdown.

To power up Seestar again, that would be a new seestar_alp session.

On Wed, Jun 26, 2024, 8:21 AM rrowley42 @.***> wrote:

WileEyte was cycling the Seestar and didn’t want to also have to cycle Seestar_alp. I can remove it if you don’t think it is good enough use case.

From: smart-underworld @.> Sent: Wednesday, June 26, 2024 10:11 AM To: smart-underworld/seestar_alp @.> Cc: rrowley42 @.>; Author @.> Subject: Re: [smart-underworld/seestar_alp] Clean up Retry logic (PR

17)

@smart-underworld commented on this pull request.

Question about shutdown logic change. This was for users to shutdown and thus power off Seestar. Why is there logic to start seestar device again?

— Reply to this email directly, view it on GitHub <

https://github.com/smart-underworld/seestar_alp/pull/17#pullrequestreview-2142189094>

, or unsubscribe <

https://github.com/notifications/unsubscribe-auth/APD2NM2RATD7V3BC533HJE3ZJLKYVAVCNFSM6AAAAABJ55FGPKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCNBSGE4DSMBZGQ>

. You are receiving this because you authored the thread.Message ID: @.***>

— Reply to this email directly, view it on GitHub <

https://github.com/smart-underworld/seestar_alp/pull/17#issuecomment-2191981580>,

or unsubscribe <

https://github.com/notifications/unsubscribe-auth/AADWZ5DATTXDLAHABWL44ELZJLL7RAVCNFSM6AAAAABJ55FGPKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJRHE4DCNJYGA>

. You are receiving this because you are subscribed to this thread.Message ID: @.***>

— Reply to this email directly, view it on GitHub <

https://github.com/smart-underworld/seestar_alp/pull/17#issuecomment-2191998218>

, or unsubscribe <

https://github.com/notifications/unsubscribe-auth/APD2NMZSWIMJ3G6RXTTP4OLZJLM4LAVCNFSM6AAAAABJ55FGPKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJRHE4TQMRRHA>

. You are receiving this because you authored the thread.Message ID: @.***>

— Reply to this email directly, view it on GitHub < https://github.com/smart-underworld/seestar_alp/pull/17#issuecomment-2192004352>,

or unsubscribe < https://github.com/notifications/unsubscribe-auth/AADWZ5BCB5NP3TWZW4W3VI3ZJLNGZAVCNFSM6AAAAABJ55FGPKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJSGAYDIMZVGI>

. You are receiving this because you commented.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/smart-underworld/seestar_alp/pull/17#issuecomment-2192182559, or unsubscribe https://github.com/notifications/unsubscribe-auth/APD2NM4TZTZF52ZDASQ4B5TZJLVUTAVCNFSM6AAAAABJ55FGPKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJSGE4DENJVHE . You are receiving this because you authored the thread.Message ID: @.***>