search

smart-underworld / seestar_alp

Complete Control and Automation for Seestar S50
Other
72 stars 32 forks source link

Focal Position setting changes on its own when saving settings page #90

Open movo-doo opened 2 months ago

movo-doo commented 2 months ago

tested 3 times and determined that the user defined focal position in the seestar app and as shown in SSC changes back to the Factory Default Focal Position when simply clicking the Save control on the Settings page. Even when no changes were made on the page. Also when users may have changed a different parameter. Environment is download from github yesterday morning and Windows OS non virtual

movo-doo commented 2 months ago

focal position log snippet.txt

added a snipped of the log file in debug mode what I believe is it setting the setting 2024-07-30T18:48:00.626 DEBUG MainThread Seestar 1 sending: {"method": "set_setting", "params": {"stack_lenhance": false, "stack_dither": {"pix": 15, "interval": 15, "enable": true}, "exp_ms": {"stack_l": 10000, "continuous": 500}, "focal_pos": 1515, "factory_focal_pos": 1482, "auto_power_off": false, "auto_3ppa_calib": true, "frame_calib": true, "stack_masic": false, "rec_stablzn": true, "manual_exp": false}, "id": 10087}

but immeditately after 2024-07-30T18:48:00.697 INFO MainThread 127.0.0.1 -> {'Action': 'method_sync', 'Parameters': '{"method": "get_setting"}', 'ClientID': 1, 'ClientTransactionID': 999} 2024-07-30T18:48:00.697 DEBUG MainThread Seestar 1 sending: {"method": "get_setting", "id": 10089} 2024-07-30T18:48:00.750 DEBUG ReceiveMessageThread.Seestar 1 Seestar 1 received : {"jsonrpc":"2.0","Timestamp":"680.411233601","method":"set_setting","error":"fail to operate","code":207,"id":10087}

{"jsonrpc":"2.0","Timestamp":"680.428774942","method":"set_stack_setting","error":"expected bool param","code":106,"id":10088}

..this is when I noticed the Settings page change the focal setting to the factory setting

quake101 commented 2 months ago

PR #91 This fixes {"jsonrpc":"2.0","Timestamp":"680.428774942","method":"set_stack_setting","error":"expected bool param","code":106,"id":10088}

This also removes factory_focal_pos as it overrides focal_pos. (It does this in Bruno as well.)

I'm not sure of the following error: {"jsonrpc":"2.0","Timestamp":"680.411233601","method":"set_setting","error":"fail to operate","code":207,"id":10087} I wasn't able to reproduce this on my Pi3 install.

movo-doo commented 2 months ago

I believe this can be closed as resolved ... I have saved a dither setting and my user defined focal position did not change. All seems to be good. I wont close it as I am not sure if Joe wants to add anything.... Thanks @quake101 Joe V

quake101 commented 2 months ago

@movo-doo You're welcome. I'm fine with closing this one.