search

smartFreshBear / RecipeGrabber

Apache License 2.0
1 stars 2 forks source link

Israel playg 48 seperate logic from services #91

Closed ILB-96 closed 1 year ago

ILB-96 commented 1 year ago

A lot of hot new changes all endpoints are working (except /train which I am not sure what it does)

Yonatanb4 commented 1 year ago

@Hazannovich Good job! Have you checked every route works properly?

ILB-96 commented 1 year ago

@Hazannovich Good job! Have you checked every route works properly?

@Yonatanb4 Yes, except The /train endpoint which I am not sure what its suppose to do. its a GET request that calls this function and return nothing. we also call the same function every time we start the app here

Yonatanb4 commented 1 year ago

@Hazannovich we need to understand what /train does before merging. This is because we may cause a problem after merging. Please speak to @aviadredis and make sure /train works properly and let me know.

ILB-96 commented 1 year ago

Hey @Yonatanb4 , I spoke to Aviad and it's ok, this Get Request isn't suppose to be used, The function inside it is running one time when you first run the app.