Closed yotam-yakovw closed 1 year ago
Fixes:
Notes:
1- let's talk a little about your commits - you almost doing it good. each commit suppose to pack an agenda of what you intended to do, which you did BUT take in account, that changes on changes you did, should be avoided as much as possible. for example: commit 1 = 'adding feature to made car faster' commit 2 = 'testing car is fast' commit 3 = 'fixing some stuff I discovered later after testing car'
will just pollute the master branch. to avoid it before updating PR we usually squash commit together (in my example 1 and 3)
2- u have a conflict fix it when u have time :)
(other comments are on they way)
fixed everything I could, would like to hear your feedback about the rewrite of the training functions and if there is a way to improve (probably...) also waiting for answer on last conversation
added 2 funcs for get and append requests to the spreadsheet api that are used by relevant methods for reading/writing data to the spreadsheet, also added func for getting the spreadsheet values resource to avoid repeating code.