smartVong / 4square

0 stars 0 forks source link

Organize more code #2

Open kittinunf opened 9 years ago

kittinunf commented 9 years ago

I saw you instantiate AFHTTPRequestOperationManager in each UIViewController subclass. For example, they are;

https://github.com/smartVong/4square/blob/master/FourSquareInfo/FIFirstViewController.m#L44-52 https://github.com/smartVong/4square/blob/master/FourSquareInfo/FIInfoViewController.m#L40-48

While this can be acceptable in a small project, it yields a tremendous negative effect in a big project. How can we improve this?

Also, can you fix this issue with opening pull request? So, that we can see the changes you made.

smartVong commented 9 years ago

I think manager is used to manage request with dependencies and every time I instantiate it in each viewcontroller what i get is actually the same manager, yes? so it is not safe if it is a big project cause it might mess up the dependencies, yes?. So, I handle each request manually without using the manager cuz the project doesnt really have dependencies

On Fri, Apr 24, 2015 at 12:51 PM, kittinunv-taskworld < notifications@github.com> wrote:

I saw you instantiate AFHTTPRequestOperationManager in each UIViewController subclass. For example, they are;

https://github.com/smartVong/4square/blob/master/FourSquareInfo/FIFirstViewController.m#L44-52

https://github.com/smartVong/4square/blob/master/FourSquareInfo/FIInfoViewController.m#L40-48

While this can be acceptable in a small project, the effect can be a landslide in a big project. How can we improve this?

— Reply to this email directly or view it on GitHub https://github.com/smartVong/4square/issues/2.