smartbgp / yabgp

:bowtie:Yet Another BGP Python Implementation
http://yabgp.readthedocs.org
Apache License 2.0
238 stars 70 forks source link

error msg to import HTTPBasicAuth #92

Closed SolomonYang closed 6 years ago

SolomonYang commented 6 years ago

(yabgp-virl)~/yabgp/bin @host> python yabgpd -h Traceback (most recent call last): File "yabgpd", line 38, in from yabgp.agent.cmd import main File "/home/solomonyang/yabgp/yabgp/agent/init.py", line 30, in from yabgp.api.app import app File "/home/solomonyang/yabgp/yabgp/api/app.py", line 21, in from yabgp.api import v1 File "/home/solomonyang/yabgp/yabgp/api/v1.py", line 21, in from flask.ext.httpauth import HTTPBasicAuth ImportError: No module named ext.httpauth

according to https://flask-httpauth.readthedocs.io/en/latest/, changed the following line in yabgp/api/v1.py

from flask.ext.httpauth import HTTPBasicAuth

to from flask_httpauth import HTTPBasicAuth

then it works well.

xiaopeng163 commented 6 years ago

thanks a lot, and welcome to submit a pull request. that will be very helpful if you like.

SolomonYang commented 6 years ago

Sorry I am not that familiar with Github pull request. I created a branch called httpAuthImportFix and committed the fix. But failed when doing git push. Not sure if I missed anything here.

~/yabgp/yabgp/api @host> git branch

~/yabgp/yabgp/api @host> git status On branch httpAuthImportFix nothing to commit, working tree clean

~/yabgp/yabgp/api @host> git push fatal: The current branch httpAuthImportFix has no upstream branch. To push the current branch and set the remote as upstream, use

git push --set-upstream origin httpAuthImportFix

~/yabgp/yabgp/api @host> git push --set-upstream origin httpAuthImportFix Username for 'https://github.com': solomon.yang@gmail.com Password for 'https://solomon.yang@gmail.com@github.com': remote: Permission to smartbgp/yabgp.git denied to SolomonYang. fatal: unable to access 'https://github.com/smartbgp/yabgp/': The requested URL returned error: 403

xiaopeng163 commented 6 years ago

thanks any way, then I will fixe that, thank you