Closed sankethkatta closed 5 years ago
Merging #22 into master will increase coverage by
23.55%
. The diff coverage is90%
.
@@ Coverage Diff @@
## master #22 +/- ##
===========================================
+ Coverage 67.59% 91.15% +23.55%
===========================================
Files 9 4 -5
Lines 250 147 -103
Branches 18 9 -9
===========================================
- Hits 169 134 -35
+ Misses 76 11 -65
+ Partials 5 2 -3
Impacted Files | Coverage Δ | |
---|---|---|
...in/java/com/smartcar/sdk/SmartcarCodeReceiver.java | 0% <ø> (ø) |
:arrow_up: |
...th/src/main/java/com/smartcar/sdk/VehicleInfo.java | 95.23% <0%> (-4.77%) |
:arrow_down: |
...c/main/java/com/smartcar/sdk/SmartcarResponse.java | 96% <0%> (-4%) |
:arrow_down: |
...h/src/main/java/com/smartcar/sdk/SmartcarAuth.java | 95.74% <94.73%> (+26.4%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 6f7ae3b...a4d41ca. Read the comment docs.
There were a lot of changes to the build system, testing files, and code interface in this PR. I pulled the Javadoc into a separate PR to make this cleaner to read.
Public Interface Changes
getAuthUrl()
has been removed completely in favor of usingAuthUrlBuilder()
authUrlBuilder()
was added to make it easier to create a builder.launchAuthFlow(..., String authUrl)
now can take in a url built by the builderaddClickHandler(..., String authUrl)
now can take in a url built by the builderauthUrl
and is just builds the default url with no additional parameters (i.e. scope, single select, ...)SmartcarAuth()
has only 2 overloaded constructors now (default live mode / test mode). I removed the feature of providingscope
as a string as all of our other SDKs only accept it as an array.Internal Changes
By setting state directly on SmartcarAuth and removing Helpers that are only used a single time we were able to remove many classes and create a simpler structure. The following classes and according tests were removed:
Helper
: All methods were trivial and only used onceApprovalPrompt
: Defined an enum that is no longer relevantResponseType
: Defined an enum that is no longer relevantSmartcarAuthRequest
: Stored state that was moved onto SmartcarAuthWebViewActivity
: We now use Chrome customtabsBuild
build
- Assembles and tests the projectjacocoTestReport
- Generates Jacoco coverage reportsEnd To End Testing
code
access_denied
error messagevehicle_incompatible
with vehicle information