smartcar / android-sdk

Smartcar Android Auth SDK
https://smartcar.github.io/android-sdk
MIT License
19 stars 2 forks source link

Refactor builder usage #22

Closed sankethkatta closed 5 years ago

sankethkatta commented 5 years ago

There were a lot of changes to the build system, testing files, and code interface in this PR. I pulled the Javadoc into a separate PR to make this cleaner to read.

I have not tried pulling this into an actual application and testing end-to-end. So DO NOT MERGE until the testing is complete!

Public Interface Changes

Internal Changes

By setting state directly on SmartcarAuth and removing Helpers that are only used a single time we were able to remove many classes and create a simpler structure. The following classes and according tests were removed:

Build

End To End Testing

codecov[bot] commented 5 years ago

Codecov Report

Merging #22 into master will increase coverage by 23.55%. The diff coverage is 90%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #22       +/-   ##
===========================================
+ Coverage   67.59%   91.15%   +23.55%     
===========================================
  Files           9        4        -5     
  Lines         250      147      -103     
  Branches       18        9        -9     
===========================================
- Hits          169      134       -35     
+ Misses         76       11       -65     
+ Partials        5        2        -3
Impacted Files Coverage Δ
...in/java/com/smartcar/sdk/SmartcarCodeReceiver.java 0% <ø> (ø) :arrow_up:
...th/src/main/java/com/smartcar/sdk/VehicleInfo.java 95.23% <0%> (-4.77%) :arrow_down:
...c/main/java/com/smartcar/sdk/SmartcarResponse.java 96% <0%> (-4%) :arrow_down:
...h/src/main/java/com/smartcar/sdk/SmartcarAuth.java 95.74% <94.73%> (+26.4%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6f7ae3b...a4d41ca. Read the comment docs.