Updated OEM display names case and sort order in picker UI

smartcar / ios-sdk

Smartcar SDK for iOS.

https://smartcar.github.io/ios-sdk/

MIT License

19 stars 7 forks source link

Updated OEM display names case and sort order in picker UI #24

Closed dvkch closed 6 years ago

dvkch commented 6 years ago

Hello everyone,

The picker UI currently uses an all-uppercase list of OEMs, this commit fixes it by using the usual case for each OEM display name. It also ensures the list is sorted while keeping mock at the end (though this should not be needed since it should be appended after the list has been sorted).

Thanks for considering

jerzzhang commented 6 years ago

Lmk when this is ready for review!

dvkch commented 6 years ago

Oops, sorry. It is :)

sankethkatta commented 6 years ago

@zz60 can this be merged?

jerzzhang commented 6 years ago

We can close this PR because this PR is dealing with the vehicle picker UI in iOS. But that option will not be available for the new iOS SDK. @sankethkatta