search

smartcar / ios-sdk

Smartcar SDK for iOS.
https://smartcar.github.io/ios-sdk/
MIT License
19 stars 7 forks source link

feat: update to swift 5 and refactor to use builder pattern for URLs #59

Closed allisonc07 closed 4 years ago

allisonc07 commented 4 years ago

iOS SDK revamp!

  1. Switch to Swift 5
  2. Use SFWebAuthenticationSession and ASWebAuthenticationSession to provide authentication support for iOS 11+
  3. Create SCUrlBuilder to create Connect URLs
  4. Add new types to AuthenticationError to support more Smartcar Connect errors
  5. Add jazzy documentation
codecov[bot] commented 4 years ago

Codecov Report

Merging #59 into master will decrease coverage by 20%. The diff coverage is 77.31%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #59    +/-   ##
=====================================
- Coverage     100%   80%   -20%     
=====================================
  Files           2     4     +2     
  Lines         114   140    +26     
=====================================
- Hits          114   112     -2     
- Misses          0    28    +28
Impacted Files Coverage Δ
SmartcarAuth/AuthorizationError.swift 100% <100%> (ø)
SmartcarAuth/SCUrlBuilder.swift 100% <100%> (ø)
SmartcarAuth/VehicleInfo.swift 100% <100%> (ø) :arrow_up:
SmartcarAuth/SmartcarAuth.swift 69.56% <63.51%> (-30.44%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d038e81...8ce6ecf. Read the comment docs.