smartcar / ios-sdk

Smartcar SDK for iOS.
https://smartcar.github.io/ios-sdk/
MIT License
19 stars 7 forks source link

Access level of AuthorizationError variables and inner ErrorType enum were updated #63

Closed anashkevichp closed 3 years ago

anashkevichp commented 3 years ago

This is a tiny PR with the main purpose to close this issue.

Access levels of type, errorDescription and enum ErrorType were updated so now we can use it outside of the SDK.

anashkevichp commented 3 years ago

Thanks for the quick reply, @allisonc07!

I can approve the PR once the version is bumped in SmartcarAuth.podspec!

Should I do this change? If so, what version would you suggest? 4.0.2?

allisonc07 commented 3 years ago

Yes, please! 4.1.1 would be great!

codecov[bot] commented 3 years ago

Codecov Report

Merging #63 (a2b3e3f) into master (3d0ddbe) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #63   +/-   ##
=======================================
  Coverage   79.54%   79.54%           
=======================================
  Files           4        4           
  Lines         132      132           
=======================================
  Hits          105      105           
  Misses         27       27           
Impacted Files Coverage Δ
SmartcarAuth/AuthorizationError.swift 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3d0ddbe...b255c35. Read the comment docs.