codecov[bot]
commented
10 months ago Codecov Report
Attention: 5 lines in your changes are missing coverage. Please review.
Comparison is base (
62bec4c) 79.54% compared to head (c019be7) 0.00%.
| Files | Patch % | Lines |
|---|---|---|
| SmartcarAuth/SmartcarAuth.swift | 0.00% | 5 Missing :warning: |
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #74 +/- ## ========================================== - Coverage 79.54% 0.00% -79.55% ========================================== Files 4 4 Lines 132 134 +2 ========================================== - Hits 105 0 -105 - Misses 27 134 +107 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
In the
launchAuthFlowmethod, we pass the redirect URI scheme toASWebAuthenticationSessionas thecallbackURLSchemeso that it is able to receive the callback from Connect. Since we enforced the redirect URI scheme to be"sc" + clientIdin the past, we could manually construct the scheme to pass toASWebAuthenticationSessionsince it would be the same format every time. However, now that we are allowing any type of custom scheme, we will need to read the scheme off of the redireURI parameter.