Closed naomiperez closed 2 years ago
Merging #102 (08ec927) into master (8863aba) will increase coverage by
1.37%
. The diff coverage is76.53%
.
@@ Coverage Diff @@
## master #102 +/- ##
============================================
+ Coverage 77.93% 79.31% +1.37%
- Complexity 185 200 +15
============================================
Files 34 37 +3
Lines 716 783 +67
Branches 44 50 +6
============================================
+ Hits 558 621 +63
- Misses 132 134 +2
- Partials 26 28 +2
Flag | Coverage Δ | |
---|---|---|
integration | 67.17% <61.37%> (+1.39%) |
:arrow_up: |
test | 50.95% <47.65%> (+3.61%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
...main/java/com/smartcar/sdk/data/Compatibility.java | 66.66% <0.00%> (ø) |
|
...ain/java/com/smartcar/sdk/SmartcarAuthOptions.java | 50.00% <50.00%> (ø) |
|
src/main/java/com/smartcar/sdk/data/User.java | 66.66% <50.00%> (ø) |
|
...com/smartcar/sdk/SmartcarCompatibilityRequest.java | 65.57% <58.06%> (ø) |
|
src/main/java/com/smartcar/sdk/Smartcar.java | 64.91% <66.07%> (-1.16%) |
:arrow_down: |
...ain/java/com/smartcar/sdk/data/ActionResponse.java | 75.00% <66.66%> (ø) |
|
...ava/com/smartcar/sdk/data/WebhookSubscription.java | 75.00% <66.66%> (ø) |
|
.../main/java/com/smartcar/sdk/SmartcarException.java | 87.20% <69.56%> (+1.81%) |
:arrow_up: |
src/main/java/com/smartcar/sdk/data/Meta.java | 80.00% <77.77%> (ø) |
|
.../java/com/smartcar/sdk/SmartcarVehicleOptions.java | 80.00% <78.94%> (ø) |
|
... and 15 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 8863aba...08ec927. Read the comment docs.
Add a new general purpose/BSE related object/method SmartcarVehicleRequest to allow making requests like so:
SmartcarVehicleRequest req = new SmarcarVehicleRequest.Builder.method("GET").path("tesla/thermometer/outside").build();
Adds request() method to Vehicle class. Adds E2E tests for this class and method.Test Plan: create an app with my Smartcar Developer account and make requests with this method once it's in staging/prod.
Asana: https://app.asana.com/0/1201332815308984/1201631034519423/f