search

smartcar / java-sdk

Java client SDK for the Smartcar API.
https://smartcar.github.io/java-sdk
MIT License
20 stars 20 forks source link

bug fix: testModeCompatibilityLevel query param camelCase -> snake_case #105

Closed zack-bender closed 2 years ago

zack-bender commented 2 years ago

The Java SDK could not be used to test Compatibility API as was always getting error response 400 VALIDATION with "detail":[{"field":"test_mode_compatibility_level","message":"Field must be one of: [compatible,phev,incompatible,fuel,dinosaur,bev]"}] even when using one of those values. The reason was that the SDK was incorrectly adding "testModeCompatibilityLevel" as the query param instead of "test_mode_compatibility_level". Fixed by this commit.

gurpreetatwal commented 2 years ago

Hi @ZechariaBender :wave: Thank you for catching this! I'll look into why CI isn't running and try to get this merged.

gurpreetatwal commented 2 years ago

Actually, I think it's because we don't allow CI for non-maintainers. I'll merge this PR and then create a follow up to cut the release

gurpreetatwal commented 2 years ago

released as v3.2.1

zack-bender commented 2 years ago

Awesome, thanks for the merge and release :)