search

smartcar / java-sdk

Java client SDK for the Smartcar API.
https://smartcar.github.io/java-sdk
MIT License
20 stars 20 forks source link

chore(VehicleTest): fix batch test case it matches a real request #109

Closed gurpreetatwal closed 2 years ago

gurpreetatwal commented 2 years ago

The current test would result in our API returning a 400 status response because it sends the request array as a string. Just fixing this so it doesn't trip up anyone else who looks to the tests to try and make real API requests :p

Asana: https://app.asana.com/0/1122465745219696/1202542055449562/f

codecov[bot] commented 2 years ago

Codecov Report

Merging #109 (f3b5e13) into master (1b365bb) will decrease coverage by 0.25%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #109      +/-   ##
============================================
- Coverage     79.16%   78.90%   -0.26%     
  Complexity      200      200              
============================================
  Files            37       37              
  Lines           787      787              
  Branches         49       49              
============================================
- Hits            623      621       -2     
- Misses          136      138       +2     
  Partials         28       28
Flag Coverage Δ
integration 66.70% <ø> (ø)
test 51.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../java/com/smartcar/sdk/SmartcarVehicleRequest.java 81.39% <0.00%> (-4.66%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1b365bb...f3b5e13. Read the comment docs.