smartcar / java-sdk

Java client SDK for the Smartcar API.
https://smartcar.github.io/java-sdk
MIT License
20 stars 20 forks source link

fix(batch): don't expect headers in error responses #118

Closed rsimari closed 2 years ago

rsimari commented 2 years ago

Asana: https://app.asana.com/0/1122465745219696/1203288266000036/f

codecov[bot] commented 2 years ago

Codecov Report

Merging #118 (52f9e89) into master (ab689f6) will increase coverage by 12.66%. The diff coverage is 100.00%.

Additional details and impacted files [![Impacted file tree graph](https://codecov.io/gh/smartcar/java-sdk/pull/118/graphs/tree.svg?width=650&height=150&src=pr&token=nZAITx7w3X&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smartcar)](https://codecov.io/gh/smartcar/java-sdk/pull/118?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smartcar) ```diff @@ Coverage Diff @@ ## master #118 +/- ## ============================================= + Coverage 65.48% 78.14% +12.66% - Complexity 171 203 +32 ============================================= Files 37 37 Lines 817 819 +2 Branches 56 57 +1 ============================================= + Hits 535 640 +105 + Misses 245 147 -98 + Partials 37 32 -5 ``` | Flag | Coverage Δ | | |---|---|---| | integration | `65.32% <33.33%> (-0.16%)` | :arrow_down: | | test | `50.79% <100.00%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smartcar#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/smartcar/java-sdk/pull/118?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smartcar) | Coverage Δ | | |---|---|---| | [...main/java/com/smartcar/sdk/data/BatchResponse.java](https://codecov.io/gh/smartcar/java-sdk/pull/118/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smartcar#diff-c3JjL21haW4vamF2YS9jb20vc21hcnRjYXIvc2RrL2RhdGEvQmF0Y2hSZXNwb25zZS5qYXZh) | `97.67% <100.00%> (+17.18%)` | :arrow_up: | | [src/main/java/com/smartcar/sdk/Vehicle.java](https://codecov.io/gh/smartcar/java-sdk/pull/118/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smartcar#diff-c3JjL21haW4vamF2YS9jb20vc21hcnRjYXIvc2RrL1ZlaGljbGUuamF2YQ==) | `95.86% <0.00%> (+6.61%)` | :arrow_up: | | [.../java/com/smartcar/sdk/SmartcarVehicleRequest.java](https://codecov.io/gh/smartcar/java-sdk/pull/118/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smartcar#diff-c3JjL21haW4vamF2YS9jb20vc21hcnRjYXIvc2RrL1NtYXJ0Y2FyVmVoaWNsZVJlcXVlc3QuamF2YQ==) | `81.39% <0.00%> (+13.95%)` | :arrow_up: | | [src/main/java/com/smartcar/sdk/ApiClient.java](https://codecov.io/gh/smartcar/java-sdk/pull/118/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smartcar#diff-c3JjL21haW4vamF2YS9jb20vc21hcnRjYXIvc2RrL0FwaUNsaWVudC5qYXZh) | `90.38% <0.00%> (+15.38%)` | :arrow_up: | | [...main/java/com/smartcar/sdk/data/VehicleCharge.java](https://codecov.io/gh/smartcar/java-sdk/pull/118/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smartcar#diff-c3JjL21haW4vamF2YS9jb20vc21hcnRjYXIvc2RrL2RhdGEvVmVoaWNsZUNoYXJnZS5qYXZh) | `50.00% <0.00%> (+16.66%)` | :arrow_up: | | [src/main/java/com/smartcar/sdk/data/Meta.java](https://codecov.io/gh/smartcar/java-sdk/pull/118/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smartcar#diff-c3JjL21haW4vamF2YS9jb20vc21hcnRjYXIvc2RrL2RhdGEvTWV0YS5qYXZh) | `80.00% <0.00%> (+20.00%)` | :arrow_up: | | [...in/java/com/smartcar/sdk/data/VehicleResponse.java](https://codecov.io/gh/smartcar/java-sdk/pull/118/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smartcar#diff-c3JjL21haW4vamF2YS9jb20vc21hcnRjYXIvc2RrL2RhdGEvVmVoaWNsZVJlc3BvbnNlLmphdmE=) | `100.00% <0.00%> (+20.00%)` | :arrow_up: | | [.../java/com/smartcar/sdk/SmartcarVehicleOptions.java](https://codecov.io/gh/smartcar/java-sdk/pull/118/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smartcar#diff-c3JjL21haW4vamF2YS9jb20vc21hcnRjYXIvc2RrL1NtYXJ0Y2FyVmVoaWNsZU9wdGlvbnMuamF2YQ==) | `82.75% <0.00%> (+24.13%)` | :arrow_up: | | [.../main/java/com/smartcar/sdk/SmartcarException.java](https://codecov.io/gh/smartcar/java-sdk/pull/118/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smartcar#diff-c3JjL21haW4vamF2YS9jb20vc21hcnRjYXIvc2RrL1NtYXJ0Y2FyRXhjZXB0aW9uLmphdmE=) | `85.38% <0.00%> (+45.38%)` | :arrow_up: | | ... and [2 more](https://codecov.io/gh/smartcar/java-sdk/pull/118/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smartcar) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/smartcar/java-sdk/pull/118?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smartcar). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smartcar) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/smartcar/java-sdk/pull/118?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smartcar). Last update [0b12569...52f9e89](https://codecov.io/gh/smartcar/java-sdk/pull/118?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smartcar). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smartcar).