search

smartcar / java-sdk

Java client SDK for the Smartcar API.
https://smartcar.github.io/java-sdk
MIT License
20 stars 20 forks source link

feat: add Chrome support and refactor browser setup #147

Closed aytekin-smartcar closed 3 months ago

aytekin-smartcar commented 4 months ago

This commit introduces the ability to use Chrome as the browser for running authentication flows in integration tests, alongside the existing Firefox setup. The browser choice is driven by the BROWSER environment variable, defaulting to Firefox if the variable is not set. The commit also includes minor code refactoring for better readability and maintainability.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.99%. Comparing base (04a4869) to head (543817e).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/smartcar/java-sdk/pull/147/graphs/tree.svg?width=650&height=150&src=pr&token=nZAITx7w3X&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smartcar)](https://app.codecov.io/gh/smartcar/java-sdk/pull/147?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smartcar) ```diff @@ Coverage Diff @@ ## Service-History-Update-SDKs-java-1207118124320958 #147 +/- ## ==================================================================================== Coverage 68.99% 68.99% Complexity 240 240 ==================================================================================== Files 50 50 Lines 1016 1016 Branches 71 71 ==================================================================================== Hits 701 701 Misses 281 281 Partials 34 34 ``` | [Flag](https://app.codecov.io/gh/smartcar/java-sdk/pull/147/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smartcar) | Coverage Δ | | |---|---|---| | [integration](https://app.codecov.io/gh/smartcar/java-sdk/pull/147/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smartcar) | `55.11% <ø> (ø)` | | | [test](https://app.codecov.io/gh/smartcar/java-sdk/pull/147/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smartcar) | `46.85% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smartcar#carryforward-flags-in-the-pull-request-comment) to find out more. ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/smartcar/java-sdk/pull/147?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smartcar). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smartcar) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/smartcar/java-sdk/pull/147?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smartcar). Last update [04a4869...543817e](https://app.codecov.io/gh/smartcar/java-sdk/pull/147?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smartcar). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smartcar).