smartcar / java-sdk

Java client SDK for the Smartcar API.

https://smartcar.github.io/java-sdk

MIT License

20 stars 20 forks source link

feat: prevent all build dependencies from being packaged into a fat jar #150

Closed davismariotti closed 3 months ago

davismariotti commented 6 months ago

Description

It isn't necessary to package all dependencies into a large "fat" jar. This change will remove all transitive dependencies from the final jar, and improve compatibility with other projects that might be operating with different versions of the same dependencies.

Fixes #107 and #139

davismariotti commented 3 months ago

Any updates on this?

Anth06ny commented 3 months ago

I have the same problème with Okhttp

s-ashwinkumar commented 3 months ago

Apologies. This slipped out of our radar. Our CI currently doesn't get triggered due to lack of access to secrets to run the tests. I have recreated the PR and will test and merge it in. Once its merged in, i will comment here and close this one.

s-ashwinkumar commented 3 months ago

This, was merged in https://github.com/smartcar/java-sdk/pull/151 , one of the owners had to recreate the PR because tests currently depend on a token that requires one of the owners. Closing this in favor of https://github.com/smartcar/java-sdk/pull/151