smartcar / java-sdk

Java client SDK for the Smartcar API.
https://smartcar.github.io/java-sdk
MIT License
20 stars 20 forks source link

feat: add support for new diagnostics endpoints #152

Closed hhovsepi closed 1 week ago

hhovsepi commented 2 weeks ago

Local testing: image

Asana: https://app.asana.com/0/1208505982103877/1208604478475173/f

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 66.21%. Comparing base (99061b1) to head (7268ed6). Report is 9 commits behind head on master.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/smartcar/java-sdk/pull/152/graphs/tree.svg?width=650&height=150&src=pr&token=nZAITx7w3X&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smartcar)](https://app.codecov.io/gh/smartcar/java-sdk/pull/152?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smartcar) ```diff @@ Coverage Diff @@ ## master #152 +/- ## ============================================ + Coverage 65.63% 66.21% +0.58% - Complexity 244 259 +15 ============================================ Files 55 59 +4 Lines 1094 1113 +19 Branches 74 74 ============================================ + Hits 718 737 +19 Misses 339 339 Partials 37 37 ``` | [Flag](https://app.codecov.io/gh/smartcar/java-sdk/pull/152/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smartcar) | Coverage Δ | | |---|---|---| | [integration](https://app.codecov.io/gh/smartcar/java-sdk/pull/152/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smartcar) | `49.86% <0.00%> (-0.32%)` | :arrow_down: | | [test](https://app.codecov.io/gh/smartcar/java-sdk/pull/152/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smartcar) | `46.09% <100.00%> (+0.93%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smartcar#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/smartcar/java-sdk/pull/152?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smartcar) | Coverage Δ | | |---|---|---| | [src/main/java/com/smartcar/sdk/Vehicle.java](https://app.codecov.io/gh/smartcar/java-sdk/pull/152?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Fcom%2Fsmartcar%2Fsdk%2FVehicle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smartcar#diff-c3JjL21haW4vamF2YS9jb20vc21hcnRjYXIvc2RrL1ZlaGljbGUuamF2YQ==) | `92.51% <100.00%> (+0.10%)` | :arrow_up: | | [...main/java/com/smartcar/sdk/data/BatchResponse.java](https://app.codecov.io/gh/smartcar/java-sdk/pull/152?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Fcom%2Fsmartcar%2Fsdk%2Fdata%2FBatchResponse.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smartcar#diff-c3JjL21haW4vamF2YS9jb20vc21hcnRjYXIvc2RrL2RhdGEvQmF0Y2hSZXNwb25zZS5qYXZh) | `97.87% <100.00%> (+0.09%)` | :arrow_up: | | [...n/java/com/smartcar/sdk/data/DiagnosticSystem.java](https://app.codecov.io/gh/smartcar/java-sdk/pull/152?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Fcom%2Fsmartcar%2Fsdk%2Fdata%2FDiagnosticSystem.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smartcar#diff-c3JjL21haW4vamF2YS9jb20vc21hcnRjYXIvc2RrL2RhdGEvRGlhZ25vc3RpY1N5c3RlbS5qYXZh) | `100.00% <100.00%> (ø)` | | | [...a/com/smartcar/sdk/data/DiagnosticTroubleCode.java](https://app.codecov.io/gh/smartcar/java-sdk/pull/152?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Fcom%2Fsmartcar%2Fsdk%2Fdata%2FDiagnosticTroubleCode.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smartcar#diff-c3JjL21haW4vamF2YS9jb20vc21hcnRjYXIvc2RrL2RhdGEvRGlhZ25vc3RpY1Ryb3VibGVDb2RlLmphdmE=) | `100.00% <100.00%> (ø)` | | | [...artcar/sdk/data/VehicleDiagnosticSystemStatus.java](https://app.codecov.io/gh/smartcar/java-sdk/pull/152?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Fcom%2Fsmartcar%2Fsdk%2Fdata%2FVehicleDiagnosticSystemStatus.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smartcar#diff-c3JjL21haW4vamF2YS9jb20vc21hcnRjYXIvc2RrL2RhdGEvVmVoaWNsZURpYWdub3N0aWNTeXN0ZW1TdGF0dXMuamF2YQ==) | `100.00% <100.00%> (ø)` | | | [...artcar/sdk/data/VehicleDiagnosticTroubleCodes.java](https://app.codecov.io/gh/smartcar/java-sdk/pull/152?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Fcom%2Fsmartcar%2Fsdk%2Fdata%2FVehicleDiagnosticTroubleCodes.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smartcar#diff-c3JjL21haW4vamF2YS9jb20vc21hcnRjYXIvc2RrL2RhdGEvVmVoaWNsZURpYWdub3N0aWNUcm91YmxlQ29kZXMuamF2YQ==) | `100.00% <100.00%> (ø)` | | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/smartcar/java-sdk/pull/152?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smartcar). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smartcar) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/smartcar/java-sdk/pull/152?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smartcar). Last update [99061b1...7268ed6](https://app.codecov.io/gh/smartcar/java-sdk/pull/152?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smartcar). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smartcar).