search

smartcar / java-sdk

Java client SDK for the Smartcar API.
https://smartcar.github.io/java-sdk
MIT License
20 stars 20 forks source link

Fix Vehicle Endpoint Bug #25

Closed GregChan closed 6 years ago

GregChan commented 6 years ago

Description

The addPathSegments function in HttpUrl.Builder class appends a / to the given path. In our usage of the builder, we passed a string with a leading slash (e.g. "/vin") to addPathSegments, which caused our built urls to resemble: https://api.smartcar.com/v1.0/4b709b6c-c50a-46a7-9239-0006d39f708f//vin.

codecov[bot] commented 6 years ago

Codecov Report

Merging #25 into master will decrease coverage by 0.06%. The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #25      +/-   ##
============================================
- Coverage     11.62%   11.56%   -0.07%     
  Complexity        9        9              
============================================
  Files            16       16              
  Lines           344      346       +2     
  Branches         14       14              
============================================
  Hits             40       40              
- Misses          304      306       +2
Impacted Files Coverage Δ Complexity Δ
src/main/java/com/smartcar/sdk/Vehicle.java 0% <0%> (ø) 0 <0> (ø) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1c47588...1ee3879. Read the comment docs.