smartcar / java-sdk

Java client SDK for the Smartcar API.
https://smartcar.github.io/java-sdk
MIT License
20 stars 20 forks source link

fix: update timeout so client has time to receive LB response #83

Closed gurpreetatwal closed 3 years ago

gurpreetatwal commented 4 years ago

References:

s-ashwinkumar commented 4 years ago

need to update doc. Keeping it approved

gurpreetatwal commented 4 years ago

Need to fix up the e2e test cases, will do tomorrow

gurpreetatwal commented 4 years ago

Will merge after #84, @allisonc07 fixed the tests in that PR

codecov[bot] commented 3 years ago

Codecov Report

Merging #83 into master will decrease coverage by 0.08%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #83      +/-   ##
============================================
- Coverage     51.16%   51.08%   -0.09%     
  Complexity       86       86              
============================================
  Files            25       25              
  Lines           600      599       -1     
  Branches         29       29              
============================================
- Hits            307      306       -1     
  Misses          282      282              
  Partials         11       11              
Flag Coverage Δ Complexity Δ
#integration 49.74% <100.00%> (-0.09%) 85.00 <0.00> (ø)
#test 5.17% <100.00%> (-0.16%) 9.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
src/main/java/com/smartcar/sdk/ApiClient.java 79.06% <100.00%> (-0.48%) 8.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 39d4f37...203eba1. Read the comment docs.