search

smartcar / java-sdk

Java client SDK for the Smartcar API.
https://smartcar.github.io/java-sdk
MIT License
20 stars 20 forks source link

feat: add country support for auth url + compatibility #84

Closed allisonc07 closed 3 years ago

allisonc07 commented 4 years ago

Changes made:

  1. Add new setFlags fn that allows users to set feature flags when generating their auth url
  2. Overload AuthClient.isCompatible to also accept a country parameter for compatibility checks for specific countries

Also updated the tests to use Tesla as well bc start/stop charge was failing with the Chevy Volt :(

codecov[bot] commented 4 years ago

Codecov Report

Merging #84 into master will decrease coverage by 0.00%. The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #84      +/-   ##
============================================
- Coverage     51.17%   51.16%   -0.01%     
- Complexity       85       86       +1     
============================================
  Files            25       25              
  Lines           596      600       +4     
  Branches         29       29              
============================================
+ Hits            305      307       +2     
- Misses          280      282       +2     
  Partials         11       11
Flag Coverage Δ Complexity Δ
#integration 49.83% <50.00%> (+<0.01%) 85.00 <1.00> (+1.00)
#test 5.33% <0.00%> (-0.04%) 9.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
src/main/java/com/smartcar/sdk/AuthClient.java 64.47% <50.00%> (-0.40%) 10.00 <1.00> (+1.00) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4edda83...ca0bf51. Read the comment docs.