search

smartcar / java-sdk

Java client SDK for the Smartcar API.
https://smartcar.github.io/java-sdk
MIT License
20 stars 20 forks source link

fix: fix buffer missuse bug #89

Closed s-ashwinkumar closed 3 years ago

s-ashwinkumar commented 3 years ago

Asana: https://app.asana.com/0/1158554234878597/1199391855563956/f

The issue was happening because response.body().string() was being called multiple times in a certain exception case source: https://github.com/square/okhttp/issues/1240

codecov[bot] commented 3 years ago

Codecov Report

Merging #89 (822a5c9) into master (526a6e4) will decrease coverage by 0.07%. The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #89      +/-   ##
============================================
- Coverage     49.59%   49.51%   -0.08%     
  Complexity       87       87              
============================================
  Files            26       26              
  Lines           619      620       +1     
  Branches         29       29              
============================================
  Hits            307      307              
- Misses          301      302       +1     
  Partials         11       11
Flag Coverage Δ Complexity Δ
integration 48.22% <0.00%> (-0.08%) 0.00 <0.00> (ø)
test 5.00% <0.00%> (-0.01%) 0.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
.../main/java/com/smartcar/sdk/SmartcarException.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 526a6e4...822a5c9. Read the comment docs.