Closed sankethkatta closed 6 years ago
Investigation revealed that the lightbox library used in the fueled-homepage (featherlight) was messing with the buttons listeners on open/close. Developers may use libs like featherlight, so our solution should be robust to work around it.
Currently the solution is to use onclick
attributes directly on the buttons. In the long-term the buttons should be rendered inside a smartcar-served iFrame.
Using native click listeners does not register properly in our demo websites. There are no errors, however clicking on the appropriate buttons does not trigger the listener:
Reproduction steps:
0.0.20
to0.0.21
. It was added back in0.0.25
./src
directory on a local serverpython3 -m http.server
.git clone git@github.com:smartcar/demos.git
.fueled-homepage.html#L91
to point the SDK script tohttp://localhost:8000/sdk.js
(or wherever you are serving it)fueled-homepage.html
in the browser and try to click on any of the Login buttons. The click listener does not trigger.NOTE: remove the
honda
make out of the list on fueled-homepage if you downgrade to an sdk version below0.0.23
.