smartcar / javascript-sdk

Client-side JS SDK for OAuth dialogs.

MIT License

9 stars 5 forks source link

feat: adds vehicle_incompatible error #43

Closed morgannewman closed 5 years ago

morgannewman commented 5 years ago

Overview

Updates SDKs to use new redirect URI scheme to be more conventional
- /redirect-2.1.1.js => /2.2.0/redirect.js
Updates redirect.js to follow major semver
- /redirect-2.1.1?... => /v2/redirect?...
Adds postinstall warning if SDK is outdated
Adds warning to the SDK constructor if using an old redirect URI
Adds vehicle_incompatible error
- Returns vehicleInfo object with the error

codecov[bot] commented 5 years ago

Codecov Report

Merging #43 into master will not change coverage. The diff coverage is n/a.

@@          Coverage Diff          @@
##           master    #43   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines          15     15           
  Branches        2      2           
=====================================
  Hits           15     15

Impacted Files	Coverage Δ
src/redirect.js	`100% <ø> (ø)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 98aecf9...6e1b60a. Read the comment docs.

morgannewman commented 5 years ago

QA Test Plan

[X] Ensure SDK is available at new URL: https://javascript-sdk.qa.smartcar.com/2.2.0/sdk.js
[X] Ensure redirect is available at the new URL: https://javascript-sdk.qa.smartcar.com/v2/redirect
[X] Ensure all legacy redirect URIs reference new redirect.js file at /v2/redirect.js

Production Test Plan

Ensure production deploys mirror QA deploy above

smartcar-ci commented 5 years ago

:tada: This PR is included in version 2.2.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: