smartcar / javascript-sdk

Client-side JS SDK for OAuth dialogs.

MIT License

9 stars 5 forks source link

fix: fixes IE11 support, Connect popup sizing, and method documentation #44

Closed morgannewman closed 5 years ago

morgannewman commented 5 years ago

IE11 does not support String.prototype.startsWith, which was used in our codebase.
- We should investigate a longer-term fix to polyfill any ES6+ method to ES5 using Gulp, but some quick googling left me with the impression that doing so is not straightforward now that babel-polyfill is deprecated; therefore, I think it's best to manually polyfill for now to get a fix out.
The Connect popup window was too small. It has been updated to be relative to your screen size.
Adds missing documentation for options objects that are passed to getAuthUrl()

codecov[bot] commented 5 years ago

Codecov Report

Merging #44 into master will not change coverage. The diff coverage is n/a.

@@          Coverage Diff          @@
##           master    #44   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines          15     15           
  Branches        2      2           
=====================================
  Hits           15     15

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fe174d3...b678258. Read the comment docs.

smartcar-ci commented 5 years ago

:tada: This PR is included in version 2.2.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: