search

smartcar / javascript-sdk

Client-side JS SDK for OAuth dialogs.
MIT License
9 stars 5 forks source link

Remove class instantiation flag #49

Closed AlbertLapTu closed 5 years ago

AlbertLapTu commented 5 years ago

There is not a need for an explicit check on how many times the Smartcar class has been instantiated.

This PR stems from an error that occurs when the onComplete callback is triggered with only one parameter. ReactDOM will swallow the thrown error that's triggered and run React's resetContextDependencies function to replay the event on a separate thread to verify that an error has been thrown.

The result of this triggers a reload of the component, which then triggers the hasBeenInstantiated error.

codecov[bot] commented 5 years ago

Codecov Report

Merging #49 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #49   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines          15     15           
  Branches        2      2           
=====================================
  Hits           15     15

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 03f48eb...9e0394b. Read the comment docs.

AlbertLapTu commented 5 years ago

Closing. Will test in prod. to verify that the change went through.