smartcar / javascript-sdk

Client-side JS SDK for OAuth dialogs.
MIT License
9 stars 5 forks source link

Support multiple instance by adding instance id #58

Closed jia-guo closed 4 years ago

jia-guo commented 4 years ago
codecov[bot] commented 4 years ago

Codecov Report

Merging #58 into master will not change coverage by %. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #58   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           15        15           
  Branches         2         2           
=========================================
  Hits            15        15           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f0325e2...c7a4a9b. Read the comment docs.

sankethkatta commented 4 years ago

The rest of the tests look good to me! Just the couple comments above. And we also need to put the right commit message to push up the new version.

jia-guo commented 4 years ago

The rest of the tests look good to me! Just the couple comments above. And we also need to put the right commit message to push up the new version.

Got it! Thanks so much for reviewing the PR!

jia-guo commented 4 years ago

@sankethkatta I tried out in mock ui & found it works as intended.

image

smartcar-ci commented 4 years ago

:tada: This PR is included in version 2.7.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: