naomiperez commented 2 years ago

Add a new general purpose/BSE related method Vehicle.prototype.request = async function( method, path, body = {}, headers = {} ) to Vehicle that allows for making requests to the Smartcar API. Also, add E2E tests for this new request method.

Test Plan: create an app with my Smartcar Developer account and make requests with this method once it's in staging/prod.

Asana: https://app.asana.com/0/1201332815308984/1201617268953141/f

codecov[bot] commented 2 years ago

Codecov Report

Merging #143 (935caae) into master (4232b70) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #143   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines          221       228    +7     
=========================================
+ Hits           221       228    +7

Impacted Files	Coverage Δ
lib/vehicle.js	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4232b70...935caae. Read the comment docs.

smartcar-ci commented 2 years ago

:tada: This PR is included in version 9.1.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

smartcar / node-sdk

feat(vehicle): add general purpose request method to Vehicle prototype #143

Codecov Report