search

smartcar / node-sdk

Smartcar Node.js SDK
MIT License
49 stars 14 forks source link

fix: set request() method arg to lowercase #146

Closed naomiperez closed 2 years ago

naomiperez commented 2 years ago

Always sets request() method argument method to lower case to allow requests like: vehicle.request("GET", "odometer")

Test Plan: use getting-started-app to test uppercase method names as arguments.

codecov[bot] commented 2 years ago

Codecov Report

Merging #146 (e5ea2ca) into master (d3a8a67) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #146   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines          228       228           
=========================================
  Hits           228       228
Impacted Files Coverage Δ
lib/vehicle.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d3a8a67...e5ea2ca. Read the comment docs.

smartcar-ci commented 2 years ago

:tada: This PR is included in version 9.1.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: