smartcar / node-sdk

Smartcar Node.js SDK
MIT License
49 stars 14 forks source link

fix: improve the batch method for BSE #156

Closed s-ashwinkumar closed 1 year ago

s-ashwinkumar commented 1 year ago

Asana: https://app.asana.com/0/1122465745219696/1203775372237134/f

Improves the batch call to add "better" support for BSEs

Using BSE goes from batchResponse["tesla/speedometer"]() to batchResponse.teslaSpeedometer()

PS: lodash camelCase can handle '/' as the conversion charachter + it also get rid of the leading '/' so overall just had to call lodash camelCase method

> _.camelCase('/tesla/speedometer')
'teslaSpeedometer'
> _.camelCase('/odometer')
'odometer'
mdheri commented 1 year ago

oh man a travis build failure :cry: i do not miss these

codecov[bot] commented 1 year ago

Codecov Report

Base: 100.00% // Head: 99.59% // Decreases project coverage by -0.41% :warning:

Coverage data is based on head (cf48a34) compared to base (06ff733). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #156 +/- ## =========================================== - Coverage 100.00% 99.59% -0.41% =========================================== Files 6 6 Lines 244 244 =========================================== - Hits 244 243 -1 - Misses 0 1 +1 ``` | [Impacted Files](https://codecov.io/gh/smartcar/node-sdk/pull/156?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smartcar) | Coverage Δ | | |---|---|---| | [lib/smartcar-service.js](https://codecov.io/gh/smartcar/node-sdk/pull/156?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smartcar#diff-bGliL3NtYXJ0Y2FyLXNlcnZpY2UuanM=) | `100.00% <100.00%> (ø)` | | | [lib/smartcar-error.js](https://codecov.io/gh/smartcar/node-sdk/pull/156?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smartcar#diff-bGliL3NtYXJ0Y2FyLWVycm9yLmpz) | `95.83% <0.00%> (-4.17%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smartcar). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smartcar)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

smartcar-ci commented 1 year ago

:tada: This PR is included in version 9.2.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: