Closed EvanPeterson1324 closed 1 year ago
Patch coverage: 100.00
% and project coverage change: +0.01
:tada:
Comparison is base (
230e41e
) 99.59% compared to head (2356efe
) 99.60%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Trying to figure out why charge/limit
is returning a validation error for setChargeLimit(.9)
in the E2E tests.
Need to figure out how to get the E2E tests running locally
RE: Running tests locally
To run tests locally, you will need geckodriver installed. One way to do this is to do a global install using npm:
https://www.npmjs.com/package/geckodriver
Then, execute the following in your shell.
E2E_SMARTCAR_CLIENT_ID="replace-with-your-client-id" E2E_SMARTCAR_CLIENT_SECRET="replace-with-your-client-secret" E2E_SMARTCAR_REDIRECT_URI="replace-with-your-redirect-uri" HEADLESS=true npm test
Replace all values with your own credentials. If you'd like to borrow mine, I can Slack it to you
Will make certain to squash merge!
:tada: This PR is included in version 9.4.0 :tada:
The release is available on:
Your semantic-release bot :package::rocket:
Overview
Adds two new functions to the vehicle object,
getChargeLimit
andsetChargeLimit
Asana: https://app.asana.com/0/1204073873904879/1204302264096972/f
Dependency additions
sinon
as a dev dependency to allow for creating spys in our test.Checklist
getChargeLimit