search

smartcar / node-sdk

Smartcar Node.js SDK
MIT License
49 stars 14 forks source link

WIP: Add request id to responses #85

Closed adolfoportilla closed 3 years ago

adolfoportilla commented 5 years ago

Note:

The following change should be a none breaking change, it adds a hidden object to the responses that return an object.

Please see the spec: https://smartcar.quip.com/34SPAvpOYTjm/Add-Request-Id to see the reasoning behind the changes.

codecov[bot] commented 5 years ago

Codecov Report

Merging #85 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #85   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           5      5           
  Lines         224    248   +24     
=====================================
+ Hits          224    248   +24
Impacted Files Coverage Δ
lib/auth-client.js 100% <100%> (ø) :arrow_up:
lib/util.js 100% <100%> (ø) :arrow_up:
lib/vehicle.js 100% <100%> (ø) :arrow_up:
index.js 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6a35fe9...42f4a3f. Read the comment docs.

s-ashwinkumar commented 3 years ago

This has been done as a part of https://github.com/smartcar/node-sdk/commit/78bd052c821481883f21826953cb98aea252bf42