search

smartcar / node-sdk

Smartcar Node.js SDK
MIT License
49 stars 14 forks source link

feat: Add Fuel and EV methods #87

Closed KarthikBhaskara closed 5 years ago

codecov[bot] commented 5 years ago

Codecov Report

Merging #87 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #87   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           5      5           
  Lines         232    252   +20     
=====================================
+ Hits          232    252   +20
Impacted Files Coverage Δ
lib/auth-client.js 100% <ø> (ø) :arrow_up:
index.js 100% <ø> (ø) :arrow_up:
lib/errors.js 100% <100%> (ø) :arrow_up:
lib/util.js 100% <100%> (ø) :arrow_up:
lib/vehicle.js 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 678ad18...0067188. Read the comment docs.

KarthikBhaskara commented 5 years ago

Super super nit comments, sorry.

Because you're removing NotCapableError, I believe this is a breaking change. Bumping the major version will be kind of annoying since you'd need to ammend a commit due to how semantic-release works, but I do think we should do it.

Will major bump. don't need to amend, i'll just set the appropriate message before squashing and merging.

smartcar-ci commented 5 years ago

:tada: This PR is included in version 7.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: